Skip to content

Fix uploading large files#482

Merged
quietsy merged 1 commit intopreviousfrom
fix-large-files-previous
Jan 9, 2025
Merged

Fix uploading large files#482
quietsy merged 1 commit intopreviousfrom
fix-large-files-previous

Conversation

@quietsy
Copy link
Copy Markdown
Member

@quietsy quietsy commented Oct 25, 2024

Fix uploading large files which is a very common support issue

@quietsy quietsy requested a review from a team October 25, 2024 13:47
@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

LinuxServer-CI commented Oct 25, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-7fa5bf48030f36fc3328f30164dee85617cee03c-pr-482/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-7fa5bf48030f36fc3328f30164dee85617cee03c-pr-482/shellcheck-result.xml

Tag Passed
amd64-previous-29.0.8-pkg-ddebef85-dev-7fa5bf48030f36fc3328f30164dee85617cee03c-pr-482 ✅
arm64v8-previous-29.0.8-pkg-ddebef85-dev-7fa5bf48030f36fc3328f30164dee85617cee03c-pr-482 ✅

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

LinuxServer-CI commented Oct 25, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-5d95254a7f8ee99078325b9e332393110d2c5dca-pr-482/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-5d95254a7f8ee99078325b9e332393110d2c5dca-pr-482/shellcheck-result.xml

Tag Passed
amd64-previous-29.0.8-pkg-ddebef85-dev-5d95254a7f8ee99078325b9e332393110d2c5dca-pr-482 ✅
arm64v8-previous-29.0.8-pkg-ddebef85-dev-5d95254a7f8ee99078325b9e332393110d2c5dca-pr-482 ✅

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

LinuxServer-CI commented Oct 25, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-e57cfdf8150b809da502b7b109d11fd551d0188e-pr-482/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-ddebef85-dev-e57cfdf8150b809da502b7b109d11fd551d0188e-pr-482/shellcheck-result.xml

Tag Passed
amd64-previous-29.0.8-pkg-ddebef85-dev-e57cfdf8150b809da502b7b109d11fd551d0188e-pr-482 ✅
arm64v8-previous-29.0.8-pkg-ddebef85-dev-e57cfdf8150b809da502b7b109d11fd551d0188e-pr-482 ✅

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

LinuxServer-CI commented Oct 31, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-7f93e87a-dev-d2dd309fe8501f76f424a04f2254f6670b9f3290-pr-482/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.8-pkg-7f93e87a-dev-d2dd309fe8501f76f424a04f2254f6670b9f3290-pr-482/shellcheck-result.xml

Tag Passed
amd64-previous-29.0.8-pkg-7f93e87a-dev-d2dd309fe8501f76f424a04f2254f6670b9f3290-pr-482 ✅
arm64v8-previous-29.0.8-pkg-7f93e87a-dev-d2dd309fe8501f76f424a04f2254f6670b9f3290-pr-482 ✅

@mmartinortiz
Copy link
Copy Markdown

mmartinortiz commented Dec 9, 2024

Any chance that this MR gets completed? There are another two MR with the same title and similar changes: #481 #480

@drizuid
Copy link
Copy Markdown
Member

drizuid commented Dec 9, 2024

Any chance that this MR gets completed? There are another two MR with the same title and similar changes: #481 #480

eventually, but nothing stops any user from following the nextcloud documentation (which is what was done) to accomplish this.

@mmartinortiz
Copy link
Copy Markdown

mmartinortiz commented Dec 10, 2024

eventually, but nothing stops any user from following the nextcloud documentation (which is what was done) to accomplish this.

If I read the documentation correctly, besides the client_max_body_size nginx parameter, we also have to change values in the php.ini file (such values are modified by this MR, in the nextcloud.ini file)

I've modified the file under php/php-local.ini as it is the only one mounted in a volume. Is this the right file to modify and get the same effect that the configuration changes of this PR?

In my case, I'm getting a "HTTPError: Response code 413 (Request Entity Too Large))" when I upload files. The same files can be uploaded via the web interface, but I read that they are uploaded in smaller chunks to avoid this issue.

@nemchik
Copy link
Copy Markdown
Member

nemchik commented Dec 10, 2024

I've modified the file under php/php-local.ini as it is the only one mounted in a volume. Is this the right file to modify and get the same effect that the configuration changes of this PR?

Yes.

@quietsy quietsy force-pushed the fix-large-files-previous branch from e57cfdf to 0f41399 Compare January 9, 2025 10:49
@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

LinuxServer-CI commented Jan 9, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.10-pkg-1eb81798-dev-0f41399c9fae6ec75149142abb655fc81512820a-pr-482/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/previous-29.0.10-pkg-1eb81798-dev-0f41399c9fae6ec75149142abb655fc81512820a-pr-482/shellcheck-result.xml

Tag Passed
amd64-previous-29.0.10-pkg-1eb81798-dev-0f41399c9fae6ec75149142abb655fc81512820a-pr-482 ✅
arm64v8-previous-29.0.10-pkg-1eb81798-dev-0f41399c9fae6ec75149142abb655fc81512820a-pr-482 ✅

@quietsy quietsy merged commit 523b71f into previous Jan 9, 2025
@quietsy quietsy deleted the fix-large-files-previous branch January 9, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nemchik nemchik nemchik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Issue & PR Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@quietsy @LinuxServer-CI @mmartinortiz @drizuid @nemchik